Date: Wed, 26 Jan 2000 14:20:03 -0800 (PST) From: "Rodney W. Grimes" <rgrimes@gndrsh.dnsmgr.net> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/10342: putenv(3) unnecessarily calls strdup/free Message-ID: <200001262220.OAA59345@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/10342; it has been noted by GNATS.
From: "Rodney W. Grimes" <rgrimes@gndrsh.dnsmgr.net>
To: peter.jeremy@alcatel.com.au (Peter Jeremy)
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/10342: putenv(3) unnecessarily calls strdup/free
Date: Wed, 26 Jan 2000 14:18:23 -0800 (PST)
> Hi Rod,
>
> I know it's been a while, but you were the last person to touch
> /usr/src/lib/libc/stdlib/putenv.c. Could you please consider
> applying the following to close PR bin/10342:
No I won't make this change:
a) This is tried and true tested code that has not been modified
since 4.4BSD Lite.
b) The man page says ``the given arguments name and value may be appended
and prepended, respectively, with an equal sign ``=''.'' It does not
say that you can have additional stuff after the =, your patch leaves
stuff after the =.
The PR eludes to a memory leak, can you be more specific on exactly how
this memory leak occurs as I do not see a memory leak in putenv as the
code is now.
--
Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001262220.OAA59345>