Date: Fri, 6 Feb 1998 10:48:18 +0100 From: Eivind Eklund <eivind@yes.no> To: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru> Cc: Eivind Eklund <eivind@yes.no>, freebsd-current@FreeBSD.ORG Subject: Re: DIAGNOSTIC kernels broken Message-ID: <19980206104818.51201@follo.net> In-Reply-To: <199802060943.MAA01329@tejblum.dnttm.rssi.ru>; from Dmitrij Tejblum on Fri, Feb 06, 1998 at 12:43:20PM %2B0300 References: <19980206010712.58740@follo.net> <199802060943.MAA01329@tejblum.dnttm.rssi.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 06, 1998 at 12:43:20PM +0300, Dmitrij Tejblum wrote: > Eivind Eklund wrote: > > On Fri, Feb 06, 1998 at 02:43:02AM +0300, Dmitrij Tejblum wrote: > > > vm/vm_zone.h depends on DIAGNOSTIC but doesn't include "opt_diagnostic.h". > ^^ > > > > Something is weird with your setup, I believe. vm_zone.c includes > ^^ > > opt_diagnostic.h as of revision 1.16, which was part of the "Turn DIAGNOSTIC > > into a new-style option" commit. > > I talk about vm_zone.h, not vm_zone.c. vm_zone.h contains several inline > functions, which depends on DIAGNOSTIC. These functions is part of vm_zone > external interface, and used in such files as kern_fork.c, and kern_exit.c, > and others, which doesn't include opt_diagnostic.h. Guilty as charged. They don't matter for an SMP kernel, which is why I didn't notice :-( I'm backing this change out and putting DIAGNOSTIC in opt_global.h. Maintaining it separately is more likely to go wrong than not. Eivind.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980206104818.51201>