Date: Mon, 31 Jul 2017 16:39:42 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Dimitry Andric <dim@FreeBSD.org>, Toomas Soome <tsoome@me.com> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Andriy Gapon <avg@FreeBSD.org> Subject: Re: tools/tools/zfsboottest doesn't compile on ^/head Message-ID: <0F46FDB8-FED5-41CD-BABD-EB0D07D85940@gmail.com> In-Reply-To: <CB48B595-C566-46E7-BB18-B9F430A16B87@gmail.com> References: <CB48B595-C566-46E7-BB18-B9F430A16B87@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jul 31, 2017, at 16:21, Ngie Cooper <yanegomi@gmail.com> wrote: > > Hi, > It looks like zfsboottest no longer compiles on ^/head (guessing it has to do with the clang upgrade). > If someone doesn’t fix this build breakage in the next few hours, I’ll take a stab at fixing it. > Thanks, > -Ngie > > PS zfsboottest should really be compiled with world if MK_ZFS != no. > > $ (cd tools/tools/zfsboottest/; make obj; make) > cc -O1 -I/usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs -I/usr/src/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs -I. -fdiagnostics-show-option -W -Wextra -Wno-sign-compare -Wno-unused-parameter -m32 -g --coverage -MD -MF.depend.zfsboottest.o -MTzfsboottest.o -std=gnu99 -fstack-protector-strong -Qunused-arguments -c /usr/src/tools/tools/zfsboottest/zfsboottest.c -o zfsboottest.o > In file included from /usr/src/tools/tools/zfsboottest/zfsboottest.c:56: > /usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs/zfsimpl.c:797:9: error: returning 'void' from a function with incompatible result type 'int' > return (pager_output(line)); > ^~~~~~~~~~~~~~~~~~~~ > /usr/src/tools/tools/zfsboottest/../../../sys/boot/zfs/zfsimpl.c:2356:17: warning: array index 264 is past the end of the array (which contains 192 elements) [-Warray-bounds] > memcpy(path, &dn->dn_bonus[sizeof(znode_phys_t)], psize); > ^ ~~~~~~~~~~~~~~~~~~~~ > /usr/src/tools/tools/zfsboottest/../../../sys/cddl/boot/zfs/zfsimpl.h:910:2: note: array 'dn_bonus' declared here > uint8_t dn_bonus[DN_MAX_BONUSLEN - sizeof (blkptr_t)]; > ^ > 1 warning and 1 error generated. > *** Error code 1 > > Stop. > make: stopped in /usr/src/tools/tools/zfsboottest > > 157873 imp void > 157873 imp printf(const char *fmt,…) > 104679 phk static void printf(const char *,...); The declaration for putchar is not ANSI compliant either — which is probably another fun hurdle that someone’s going to have to deal with in terms of fixing sys/boot and libstand. Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZf7+/AAoJEPWDqSZpMIYVTd8P/itk5p6law0iQd8n6If/9DgI py6TZhD+N8F+3yI7R2H0T5JN9anhuTWDkhscBdPMiiO6Ez9mkG7V4zIjdr1DgyKs F6qmkJ1kV2XWoMlmudRfV+wm04RNGL9L9jLB3ICBHEEQ6pLknMk4DSPNciBRI3nK KWcN8gcxyiSBvUSrZZDuspSNF3W4QEg3Hoq/Rt+tjcpGvLLR8Cpz9/DDyGWmTgyu nbPLNMpTwyHVLkJc0a8vTRvH5RMmDWtuuDBc5Cn8KeNc2U4FSNheyKp5TDXWcqs8 /Bs05CzUWgEZs5mhSrjWfGvjy2sBdRyudZt+ZTuicIedmgN5bT/i55loegc/7vQ8 7yHLyRMK9LpR4KybohbhAesfXti5ph+jUzSQkY3+XM/M2G3It9Fk0y9p9iIBw6eE Cn7Yrrq1gA0pglkeoiXlQSLqlB+8hUuBZF2eULX6X/XjB6CYdQf+mTKXuk8/2uuM 1EYzleibca2mWtYKTjLs5sLIFl+//FEPJKRC4tHTx1TLv2M45W5PcVLSAaSe5K/C 6vUaVhS1K0h/JqEoBUDRzE03++d5MSNUNmT4VijlKpNdUp1VEp8FaWesJWOgJN1v ljcAn1lO7nxilrc3kypudWTbAByG9Xytu8GPu2mVjXsDKmEmVCYyG5GnAlZ4Zq+y 2zsucftXyqjMZCxD1N4j =EoC8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0F46FDB8-FED5-41CD-BABD-EB0D07D85940>