Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Oct 2007 19:31:44 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 127073 for review
Message-ID:  <200710011931.l91JViwF026548@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help

http://perforce.freebsd.org/chv.cgi?CH=127073

Change 127073 by hselasky@hselasky_laptop001 on 2007/10/01 19:31:37

	
	Remove misleading comments.
	
	There is no limitation on the buffer size 
	hence we are using the "proxy_buffer" flag.

Affected files ...

.. //depot/projects/usb/src/sys/dev/ata/ata-usb.c#19 edit
.. //depot/projects/usb/src/sys/dev/usb/umass.c#25 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/ata/ata-usb.c#19 (text) ====

@@ -48,7 +48,7 @@
 #include <dev/ata/ata-all.h>
 #include <ata_if.h>
 
-#define	ATAUSB_BULK_SIZE (1<<17) /* don't set this lower than (1 << 16) */
+#define	ATAUSB_BULK_SIZE (1<<17)
 
 /* Command Block Wrapper */
 struct bbb_cbw {

==== //depot/projects/usb/src/sys/dev/usb/umass.c#25 (text+ko) ====

@@ -156,7 +156,7 @@
 #define	DPRINTF(...) do { } while (0)
 #endif
 
-#define	UMASS_BULK_SIZE (1 << 17) /* bytes, must not be less than (1<<16) */
+#define	UMASS_BULK_SIZE (1 << 17)
 #define	UMASS_CBI_DIAGNOSTIC_CMDLEN 12 /* bytes */
 #define	UMASS_MAX_CMDLEN MAX(12, CAM_MAX_CDBLEN) /* bytes */
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710011931.l91JViwF026548>