Date: Tue, 3 Jan 2017 12:26:22 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Pedro Giffuni <pfg@FreeBSD.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311109 - head/usr.bin/patch Message-ID: <20170103102622.GO1923@kib.kiev.ua> In-Reply-To: <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> References: <201701021823.v02INWXc028047@repo.freebsd.org> <CAG6CVpUUFoTZBO0Ja2aSn%2BeMi_BO0u131YKQ1yQumu%2BdRhVY3A@mail.gmail.com> <aa9172cb-cb95-36cf-c21d-48f8a7450ad5@FreeBSD.org> <CAG6CVpV7=Dx6VywV0MRY7z7LMwQrBcb-1qUhjngxjFsSZZHvHg@mail.gmail.com> <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 02, 2017 at 07:41:26PM -0500, Pedro Giffuni wrote: > > > On 01/02/17 17:54, Conrad Meyer wrote: > > I was suggesting using UINT32_MAX/2 on all platforms (which is safe > > everywhere). > > > > Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. > I just think it's clearer to use INT_MAX and the corresponding int > type. > > The other issue is if diff(1) can handle such lines(?). Of course it cannot, on ILP32 arches.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170103102622.GO1923>