Date: Tue, 8 Feb 2005 03:43:02 +0000 (UTC) From: Scott Long <scottl@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/twe twe.c twe_freebsd.c Message-ID: <200502080343.j183h2Nt041950@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
scottl 2005-02-08 03:43:02 UTC
FreeBSD src repository
Modified files:
sys/dev/twe twe.c twe_freebsd.c
Log:
Fix crashdumps on twe. The twe_immediate_request() path was not only
copying data to a temporary buffer before the I/O, but also copying that
temporary buffer back to the original data location after the I/O. When
you're dumping kernel heap and stack and protected pages, this is very
very bad.
A belated thanks to Robert Watson for donating hardware for this (and future)
work.
MFC after: 3 days
Revision Changes Path
1.24 +24 -9 src/sys/dev/twe/twe.c
1.40 +1 -3 src/sys/dev/twe/twe_freebsd.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502080343.j183h2Nt041950>