Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Sep 2025 00:47:39 GMT
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d9ae618c0816 - main - [rtwn] don't send NULL data frames if we're compiled with firmware enabled
Message-ID:  <202509200047.58K0ldcL017070@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by adrian:

URL: https://cgit.FreeBSD.org/src/commit/?id=d9ae618c0816d24bc8127e479db5787c97a23140

commit d9ae618c0816d24bc8127e479db5787c97a23140
Author:     Adrian Chadd <adrian@FreeBSD.org>
AuthorDate: 2025-08-27 17:04:39 +0000
Commit:     Adrian Chadd <adrian@FreeBSD.org>
CommitDate: 2025-09-20 00:44:19 +0000

    [rtwn] don't send NULL data frames if we're compiled with firmware enabled
    
    the firmware should be sending these.
    
    Differential Revision:  https://reviews.freebsd.org/D52298
    Reviewed by: bz
    
    Locally tested:
    
    * rtl8821/rtl8812au (STA)
---
 sys/dev/rtwn/if_rtwn.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sys/dev/rtwn/if_rtwn.c b/sys/dev/rtwn/if_rtwn.c
index 25287f222270..c5889937fb08 100644
--- a/sys/dev/rtwn/if_rtwn.c
+++ b/sys/dev/rtwn/if_rtwn.c
@@ -271,6 +271,11 @@ rtwn_attach(struct rtwn_softc *sc)
 	/* Enable seqno offload */
 	ic->ic_flags_ext |= IEEE80211_FEXT_SEQNO_OFFLOAD;
 
+#ifdef RTWN_WITHOUT_UCODE
+	/* Don't originate NULL data frames - let firmware do this */
+	ic->ic_flags_ext |= IEEE80211_FEXT_NO_NULLDATA;
+#endif
+
 	/* Adjust capabilities. */
 	rtwn_adj_devcaps(sc);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509200047.58K0ldcL017070>