Date: Mon, 20 Aug 2007 11:11:36 +0200 From: Roman Divacky <rdivacky@FreeBSD.org> To: Jesper Brix Rosenkilde <jbr@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 125372 for review Message-ID: <20070820091136.GA47764@freebsd.org> In-Reply-To: <200708200201.l7K21c3v034586@repoman.freebsd.org> References: <200708200201.l7K21c3v034586@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> + PROC_LOCK(p); > outsysshm.pid = p->p_pid; > - strncpy(outsysshm.progtitle, p->p_comm, MAXCOMLEN); > - strncpy(outsysshm.proctitle, "\0", 1); > - copyout((caddr_t) &outsysshm, (caddr_t) *addr, sizeof(struct sysshm)); > + copyout(&outsysshm, (vm_offset_t *) p->p_usrsysshm, > + sizeof(struct sysshm)); > + PROC_UNLOCK(p); I dont think you can copyout while holding proc lock.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070820091136.GA47764>