Date: Sun, 4 Jan 2015 05:01:59 +0000 From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org> To: freebsd-toolchain@freebsd.org Subject: [Differential] [Commented On] D1428: readelf: Handle note types from different operating systems Message-ID: <adbc2fb2bdf8d038d351ea6acb040f01@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-lsl5z2duoaqvef2padti-req@FreeBSD.org> References: <differential-rev-PHID-DREV-lsl5z2duoaqvef2padti-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
emaste added a comment. >>! In D1428#3, @rpaulo wrote: > This looks odd. Why are we relying on magic numbers instead of constants/enums like before? Some of the constants in the previous version are Linux-specific, and don't exist in our ELF headers. We could make up our own constants (e.g. NT_LINUX_AUXV) but it doesn't seem like that would provide much value. The same constant name may have different values on different OSes. REVISION DETAIL https://reviews.freebsd.org/D1428 To: emaste Cc: rpaulo, freebsd-toolchain
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?adbc2fb2bdf8d038d351ea6acb040f01>