Date: Mon, 5 Feb 2018 16:37:20 -0500 From: Ed Maste <emaste@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Wojciech Macek <wma@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328610 - head/sys/amd64/amd64 Message-ID: <CAPyFy2B=sN2RVJDzGn-Ak1oT9AW5jyz4hg8bw0Jg4%2BoWK1BH_g@mail.gmail.com> In-Reply-To: <3114578.qyyx4qh6ii@ralph.baldwin.cx> References: <201801302329.w0UNTRHn080138@repo.freebsd.org> <3195814.6PcFLP86qD@ralph.baldwin.cx> <CAPyFy2AmU%2B1pPNU=W_FbG2=u4xKXNQHifaruOH6b=W%2Bn1juw_Q@mail.gmail.com> <3114578.qyyx4qh6ii@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 January 2018 at 11:14, John Baldwin <jhb@freebsd.org> wrote: > On Wednesday, January 31, 2018 10:31:36 AM Ed Maste wrote: >> On 30 January 2018 at 21:01, John Baldwin <jhb@freebsd.org> wrote: >> > On Tuesday, January 30, 2018 11:29:27 PM John Baldwin wrote: >> >> Author: jhb >> >> Date: Tue Jan 30 23:29:27 2018 >> >> New Revision: 328610 >> >> URL: https://svnweb.freebsd.org/changeset/base/328610 >> >> >> >> Log: >> >> Ensure 'name' is not NULL before passing to strcmp(). >> >> >> >> This avoids a nested page fault when obtaining a stack trace in DDB if >> >> the address from the first frame does not resolve to a known symbol. >> >> >> >> MFC after: 1 week >> >> Sponsored by: Chelsio Communications >> > >> > This appears to be fallout from lld? After fixing this, the stack trace >> > for my next panic shows no symbols for functions in the kernel, only >> > functions in kernel modules: >> >> It's fallout from loader changes in r328536. I reverted r328536 (and >> r328603) locally and stack traces are fixed. > > Ouch. I'll try to look at this later today unless someone else beats me to > it. I committed a band-aid fix in r328826 but it still needs more investigation / proper fix.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2B=sN2RVJDzGn-Ak1oT9AW5jyz4hg8bw0Jg4%2BoWK1BH_g>