Date: Wed, 06 Jul 2016 23:14:43 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 210882] [PATCH] ipfw sched show output garbled after r270424 Message-ID: <bug-210882-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210882 Bug ID: 210882 Summary: [PATCH] ipfw sched show output garbled after r270424 Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Keywords: patch, regression Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: madpilot@FreeBSD.org CC: melifaro@FreeBSD.org Created attachment 172183 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172183&action=edit ipfw-sched-show-patch I noticed the output of "ipfw sched show" became garbled in recent head, for example: 00001: 460.000 Kbit/s 0 ms burst 5120 sched 1 type QFQ flags 0x0 0 buckets 1 active Children flowsets: 16 15 14 13 12 11 BKT Prot ___Source IP/port____ ____Dest. IP/port____ Tot_pkt/bytes Pkt/Byte Drp 0 ip 0.0.0.0/0 0.0.0.0/0 309679 166803112 0 0 181 00002: 7.424 Mbit/s 0 ms burst 10240 sched 2 type QFQ flags 0x0 0 buckets 1 active Children flowsets: 26 25 24 23 22 21 0 ip 0.0.0.0/0 0.0.0.0/0 309679 166803112 0 0 181 0 ip 0.0.0.0/0 0.0.0.0/0 411158 519899222 0 0 0 00003: 350.000 Kbit/s 0 ms burst 5120 sched 3 type QFQ flags 0x0 0 buckets 1 active Children flowsets: 31 0 ip 0.0.0.0/0 0.0.0.0/0 309679 166803112 0 0 181 0 ip 0.0.0.0/0 0.0.0.0/0 411158 519899222 0 0 0 0 ip 0.0.0.0/0 0.0.0.0/0 8465 12575050 34 50524 8 The script keeps appending things to the buffer after printing them. Attached patch adds a buffer flush after printing it. BTW there is also a change in output due to the toPrint check just above my change. It used to print the header after each scheduler. I'm going to test a patch for this issue too and attach it here if I get something working. CCing melifaro as he's the author of the commit which caused the regression. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-210882-8>