Date: Sun, 24 May 2026 01:20:20 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Jilles Tjoelker <jilles@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1df431576f99 - main - sh/tests: Cut down builtins/read12.0 by 2 seconds Message-ID: <86h5nx3e8b.fsf@ltc.des.dev> In-Reply-To: <6a120625.45836.5e8588e2@gitrepo.freebsd.org> (Jilles Tjoelker's message of "Sat, 23 May 2026 19:55:17 %2B0000") References: <6a120625.45836.5e8588e2@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Jilles Tjoelker <jilles@FreeBSD.org> writes: > commit 1df431576f99c3cc26dd4ceb1a6eda864cc9f196 > Author: Jilles Tjoelker <jilles@FreeBSD.org> > AuthorDate: 2026-05-23 19:47:15 +0000 > Commit: Jilles Tjoelker <jilles@FreeBSD.org> > CommitDate: 2026-05-23 19:47:15 +0000 > > sh/tests: Cut down builtins/read12.0 by 2 seconds > > Since the test assumes a 250 ms response time, there is no need to delay > for 3 seconds. Instead, delay for the minimum possible 1 second. > > Also, fix some assertions in builtins/read11.0 and builtins/read12.0. If > `set -e` is in effect, `foo` in `foo && bar` is considered tested and > therefore a failure does not cause the shell to exit. > > Reviewed by: bdrewery > Differential Revision: https://reviews.freebsd.org/D55191 I said no, several times. I also showed you how to speed up your tests by much more than thte two seconds you save here. Furthermore, I asked you several times to explain the login in this sentence: > Since the test assumes a 250 ms response time, there is no need to delay > for 3 seconds. Instead, delay for the minimum possible 1 second. and you were unable to. Please revert the non-functional parts of this change. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86h5nx3e8b.fsf>