Date: Wed, 18 Aug 2010 21:58:31 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Oliver Fromme <olli@lurza.secnetix.de> Cc: walter@pelissero.de, bug-followup@freebsd.org, freebsd-geom@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters Message-ID: <20100818185831.GX2396@deviant.kiev.zoral.com.ua> In-Reply-To: <201008181706.o7IH6Q3q042332@lurza.secnetix.de> References: <201008181650.o7IGo3vu096176@freefall.freebsd.org> <201008181706.o7IH6Q3q042332@lurza.secnetix.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--b6tME5Uow9dgAUD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote: > Oliver Fromme wrote: > > I have reviewed the patch (the second one from the followup), > > and it looks good to me, except for a few minor style(9) > > issues, and one type problem: By default, char is unsigned, > ^^^^^^^^^^^^^^^^^^ > > so the comparisons p <=3D ' ' and p > '~' probably don't do > > what you expect. >=20 > I'm sorry, I meant signed, of course. > You need to specify "unsigned char" if you want it to be unsigned. Signedness of char is implementation-depended. It is signed on x86-oids, and unsigned on powerpc, AFAIR. --b6tME5Uow9dgAUD7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxsLVcACgkQC3+MBN1Mb4jcDQCfUYofBvJScewmXBYPLljLETSO 798An0wmSPW4dbr4fReYCvPaN/9AbLdl =sCVM -----END PGP SIGNATURE----- --b6tME5Uow9dgAUD7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100818185831.GX2396>