Date: Sat, 27 Jan 2018 16:08:59 -0700 From: Ian Lepore <ian@freebsd.org> To: Conrad Meyer <cem@freebsd.org>, Pedro Giffuni <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328486 - head/usr.bin/fortune/fortune Message-ID: <1517094539.1517.9.camel@freebsd.org> In-Reply-To: <CAG6CVpXXUSPwUsxqXhJBfq_f-FwFAWXO4uQu4f2evWet90fBNg@mail.gmail.com> References: <201801271743.w0RHh9io022619@repo.freebsd.org> <CAG6CVpUOxtE9p8OApL6LsUJWh5tTM_9647M0qe5VNSnTTSEvQw@mail.gmail.com> <1f1eb186-8f7b-6ec9-0970-d8b82b909e7b@FreeBSD.org> <CAG6CVpXXUSPwUsxqXhJBfq_f-FwFAWXO4uQu4f2evWet90fBNg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2018-01-27 at 22:56 +0000, Conrad Meyer wrote: > I don˙t think dragonfly has anything to do with this? If you˙re > converting > bool increments to setting true values in FreeBSD, use > ´true.ˇ That˙s all > there is to it. > > Best, > Conrad style(9) emphasizes internal consistancy in several places. The uppercase TRUE/FALSE is currently the style within that code, so it makes sense to stick with it. If a (somewhat gratuitous) conversion to the new style is made, it should be a separate commit just for that, emphasizing that it changes just style and not functionality. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1517094539.1517.9.camel>