Date: Mon, 3 Jun 2019 18:24:31 +0200 From: Niclas Zeising <zeising@freebsd.org> To: Andriy Gapon <avg@FreeBSD.org>, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: jmd@freebsd.org Subject: Re: svn commit: r348355 - head/sys/dev/iicbus Message-ID: <10eb223b-5c18-99a0-4eb5-97acd9f91807@freebsd.org> In-Reply-To: <f4291764-09e3-2870-9e33-362ae1423c4b@FreeBSD.org> References: <201905290908.x4T98L89066643@repo.freebsd.org> <c3f1c60b-24b2-6098-501a-8cb81ef66d57@freebsd.org> <def030c0-80a5-84ca-bb48-7009aa34e69c@FreeBSD.org> <d1128088420c6e52721fb5df2280ca73096bf5c0.camel@freebsd.org> <ac9ae4b6-4b89-1e5f-9116-dcf20fee7e85@freebsd.org> <cda9c032-f0ab-7bf5-9d6f-c6167b1cf9ff@FreeBSD.org> <75cec0b83709f48bbd52e2444d7af17569093f60.camel@freebsd.org> <f4291764-09e3-2870-9e33-362ae1423c4b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-06-03 17:19, Andriy Gapon wrote: > On 03/06/2019 17:52, Ian Lepore wrote: >> Please don't. We still have a situation where nobody has shown a >> runtime failure at all. This build failure could be fixed by simply >> defining a do-nothing iicbus_set_nostop() function if a quick fix is >> needed. > > Well, I am quite certain that the run-time failure will follow after the build > time failure is fixed. > >> Putting this nostop concept into code that is shared by many drivers is >> an abomination. We have exactly one driver that needs this >> functionality, so the right fix is to implement it wholly within that >> one driver. I'll put together a diff for that. > > That's true that we have just one such driver. > At the same time, the "no stop" (or rather, repeated start) behavior makes more > sense. If stop+start between transfers are needed then that can be done with > multiple calls to iicbus_transfer. If multiple messages are given to > iicbus_transfer, then it's reasonable to assume that a repeated started is > wanted between them. But it would be a big change to review and, if needed, fix > or tidy up all code that uses iicbus_transfer. So, iicbus_set_nostop() could be > just a small step towards the bigger goal. > > But I really don't have a strong opinion. > Fixing drm2 directly is just as good for me as iicbus_set_nostop. > Hi! From my perspective, either solution is fine, as long as the drm-legacy drivers keep on working, and I get some help fixing the issue. Is there any way we can revert this change while we're discussing the best solution to this? Regards -- Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?10eb223b-5c18-99a0-4eb5-97acd9f91807>