Date: Mon, 16 Dec 2019 14:27:12 -0800 From: pete wright <nomadlogic@gmail.com> To: freebsd-current@freebsd.org Subject: error building scsi_da.c with recent current Message-ID: <CAGBmCT7RG5NnukvkM=FR%2Bnt3Q=51PkVzZwOVTnvgowfTsGspJg@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
here's the error i'm getting when building:
/usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: expected
identifier
SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN,
^
/usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from
macro 'OID_AUTO'
#define OID_AUTO (-1)
^
/usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type
specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN,
^
/usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this
function declaration is not a prototype [-Werror,-Wstrict-prototypes]
SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN,
^
3 errors generated.
*** [scsi_da.o] Error code 1
might be this commit?
commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master,
origin/master, origin/HEAD)
Author: imp <imp@FreeBSD.org> <imp@FreeBSD.org>
Date: Mon Dec 16 18:16:44 2019 +0000
Implement a system-wide limit or da and ada devices for delete.
Excesively large TRIMs can result in timeouts, which cause big
problems. Limit trims to 1GB to mititgate these issues.
Reviewed by: scottl
Differential Revision: https://reviews.freebsd.org/D22809
if there is any additional info needed happy to provide it.
cheers,
-pete
--
pete wright
www.nomadlogic.org
@nomadlogicLA
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGBmCT7RG5NnukvkM=FR%2Bnt3Q=51PkVzZwOVTnvgowfTsGspJg>