Date: Sat, 17 May 2014 13:08:45 -0400 From: Warner Losh <imp@bsdimp.com> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, "O. Hartmann" <ohartman@zedat.fu-berlin.de>, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r266278 - head/share/mk Message-ID: <7FEE0AEE-A055-4257-8C51-C01B562DCEED@bsdimp.com> In-Reply-To: <BD14AC37-7DED-4BBC-B673-04F7E0E85DF4@FreeBSD.org> References: <201405170147.s4H1l6nW081735@svn.freebsd.org> <BA29CF33-3E4A-44A1-A3B4-A58590581484@FreeBSD.org> <3ADF8926-8AEF-4324-A205-2E7D8D5393A2@bsdimp.com> <BD14AC37-7DED-4BBC-B673-04F7E0E85DF4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 17, 2014, at 10:57 AM, Dimitry Andric <dim@freebsd.org> wrote: > On 17 May 2014, at 16:27, Warner Losh <imp@bsdimp.com> wrote: >>=20 >> On May 17, 2014, at 9:56 AM, Dimitry Andric <dim@FreeBSD.org> wrote: >>=20 >>> On 17 May 2014, at 03:47, Warner Losh <imp@FreeBSD.org> wrote: >>>> Author: imp >>>> Date: Sat May 17 01:47:06 2014 >>>> New Revision: 266278 >>>> URL: http://svnweb.freebsd.org/changeset/base/266278 >>>>=20 >>>> Log: >>>> Read in SRCCONF early and consistently, if src.sys.mk exists, which = is >>>> should for all normal builds. Read /etc/make.conf earlier than = before, >>>> but consistently before SRCCONF and local.sys.mk. >>>=20 >>> I'm not yet sure why, but this breaks buildworld badly. During = bootstrap-tools, you immediately get: >>=20 >> Haven=92t seen this in my testing. Please send me your /etc/make.conf = and /etc/src.conf. Or tell me your environment. Would love to fix it... >=20 > Try an empty make.conf (or __MAKE_CONF=3D/dev/null), and just this = line in src.conf: >=20 > CXXFLAGS+=3D -std=3Dc++11 >=20 > That breaks it. We define CXXFLAGS later rather than sooner now. CXXFLAGS ?=3D = ${CFLAGS:N-std=3D*:N-Wnested-externs:N-W*-prototypes:N-Wno-pointer-sign:N-= Wold-style-definition} would have been executed, but the change caused that to not happen = (since you effectively set CXXFLAGS to -std=3Dc++11). I=92m not sure what I think of this breakage, but I=92ll look into = correcting it. I=92m not really sure what the proper fix is though=85 Warner --Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTd5eeAAoJEGwc0Sh9sBEAb+oQAODPfL2zM+wn0Cngo3QstBEa tuc/+WkSAY6LxlohSNWXFi13ilMXiB6v61r/Rf+eRTHilA+hfwiGS5YCNc6bBGry RR09VBBdVFg8rwBspNi4R2XUvBA/yN+yufIOFUOb067vQl7jI8n4U0D97Bue/C7B t/ds8+wZIU23RLze3PIdDAWvlKWqui4e36vKkMKhSc2d3Og9ak4hHjygSmvEj78q 932nweOE/KMECDt+B5FnybaOZ0YNvE3DIhyWnjeX0rhUCu6YH9nGXJlizzY7dLre EWe+8blGJ95qK9uybyl5p90xC+QSL459ux9ro+f5USCbYt0wGq2jpTkDOQSmQGM2 DgNV35o+jfPi1+n0WlTZyadYN0NuSZJ5KBRnCFb7J/Kbc1bqFRkxkaR9BZTMl7qO 878V1gTgp9yHRbZ+4/rGbR622WmSojsRA3nBBSlrU2ejCxCTvaNxypwtNbjw/UFc bF4FQHE5mUFFfk/yQ0CMtRJbfrM9GZxVnh4E5TiQy9KOsOQqYVzZzhMn5DIcZKKt SaJMRPLanVv0rM7/NGlBDNHpWyqJK3yJTljT7kkvQfol+vFhQWf3dvibvMw6OvZD n7evhH4/xOrbvybBQMFWnEeotZIxrqGQMEQ82py7KtS5t5Oeuz3L3h8dRAzHcLTs U77G9uWxpO5Fp1DuEwzE =2Pzu -----END PGP SIGNATURE----- --Apple-Mail=_AFBCE886-6710-44BE-A989-ED3F195BA4D6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7FEE0AEE-A055-4257-8C51-C01B562DCEED>