Date: Mon, 11 Jan 2016 07:03:32 -0800 From: Ravi Pokala <rpokala@mac.com> To: "Andrey V. Elsukov" <bu7cher@yandex.ru>, Ravi Pokala <rpokala@mac.com>, Allan Jude <allanjude@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292788 - in head/sys: geom/part sys Message-ID: <12E970B9-E993-4071-B334-021AB155D0B4@panasas.com> In-Reply-To: <56936975.9000202@yandex.ru> References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> <56936975.9000202@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message----- From: <owner-src-committers@freebsd.org> on behalf of "Andrey V. Elsukov" <= bu7cher@yandex.ru> Date: 2016-01-11, Monday at 00:36 To: Ravi Pokala <rpokala@mac.com>, Allan Jude <allanjude@FreeBSD.org>, <src= -committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.o= rg> Subject: Re: svn commit: r292788 - in head/sys: geom/part sys >On 11.01.16 07:54, Ravi Pokala wrote: >> In that review, there was discussion about the sorting of aliases in >(enum g_part_alias). It was originally thought that the aliases needed >to be sorted, due to binary searching in g_part_alias_name(). It turned >out that g_part_alias_name() did a linear search, so the list didn't >strictly need to be sorted. But, there was talk of potentially switching >to a binary search later, so Allan went with the sorted version. > >Hi, > >no, my note was relate to the following possible problem: >you have some stable/10 and some geom_part_panasas module installed from >the ports in the /boot/modules. When you rebuild the kernel after >merging r292788 your module will use old values of g_part_alias and thus >it will get not the same aliases. You will need rebuild your module to >fix this. Right, I explained your concerns later down in the email. However, I don't = think they're applicable, because it doesn=E2=80=99t look like anything is actuall= y using the enum outside of GEOM_PART driver. Thanks, Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?12E970B9-E993-4071-B334-021AB155D0B4>