Date: Fri, 4 Jan 2019 11:14:55 -0800 From: Manfred Antar <manfredantar@gmail.com> To: FreeBSD Current <freebsd-current@freebsd.org> Cc: markj@freebsd.org, Conrad Meyer <cem@freebsd.org>, oshogbo@freebsd.org Subject: revision 342699 breaks savecore when WITHOUT_DYNAMICROOT=yes is defined in src.conf amd64 current Message-ID: <37342A59-3F95-45A3-8B84-09750E31E325@gmail.com>
index | next in thread | raw e-mail
sbin/savecore broken when WITHOUT_DYNAMICROOT is defined:
/usr/local/bin/ccache cc -O2 -pipe -DWITH_CASPER -MD -MF.depend.savecore.o -MTsavecore.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /usr/src/sbin/savecore/savecore.c -o savecore.o
cc -O2 -pipe -DWITH_CASPER -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -static -o savecore savecore.o -L/usr/obj/usr/src/amd64.amd64/lib/libxo -lxo -L/usr/obj/usr/src/amd64.amd64/lib/libutil -lutil -L/usr/obj/usr/src/amd64.amd64/lib/libz -lz -L/usr/obj/usr/src/amd64.amd64/lib/libcasper/libcasper -lcasper -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv -L/usr/obj/usr/src/amd64.amd64/lib/libcap_fileargs -lcap_fileargs -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv -L/usr/obj/usr/src/amd64.amd64/lib/libcasper/services/cap_syslog -lcap_syslog -L/usr/obj/usr/src/amd64.amd64/lib/libnv -lnv
ld: error: unable to find library -lcasper
ld: error: unable to find library -lcap_fileargs
ld: error: unable to find library -lcap_syslog
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** Error code 1
Stop.
make: stopped in /usr/src/sbin/savecore
The recent change r342699 breaks static link:
.include <src.opts.mk>
.if ${MK_CASPER} != "no" && !defined(RESCUE)
CFLAGS+= -DWITH_CASPER
LIBADD+= casper cap_fileargs cap_syslog
.endif
I think something like this is needed to when defining WITHOUT_DYNAMICROOT:
.include <src.opts.mk>
.if ${MK_CASPER} != "no" && !defined(RESCUE) && !defined(WITHOUT_DYNAMICROOT)
CFLAGS+= -DWITH_CASPER
LIBADD+= casper cap_fileargs cap_syslog
.endif
Manfred
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37342A59-3F95-45A3-8B84-09750E31E325>