Date: Sat, 9 Jun 2018 08:55:32 -0700 From: Eitan Adler <eadler@freebsd.org> To: Florian Smeets <flo@smeets.xyz> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334864 - head/usr.bin/top Message-ID: <CAF6rxg=UcWoKQeKRjWdDJ4WV9LtffsxXciv4nZzwJZpXB=YyeQ@mail.gmail.com> In-Reply-To: <CAF6rxg=65V4YVTym=hyZqKLPV2LTKhhCYT_PDFnWjL8GPben5w@mail.gmail.com> References: <201806090214.w592EYsJ056425@repo.freebsd.org> <06a78fe9-defe-d798-3764-4f1df521538f@smeets.xyz> <CAF6rxg=65V4YVTym=hyZqKLPV2LTKhhCYT_PDFnWjL8GPben5w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 June 2018 at 08:54, Eitan Adler <eadler@freebsd.org> wrote: > On 8 June 2018 at 23:13, Florian Smeets <flo@smeets.xyz> wrote: >> On 09.06.18 04:14, Eitan Adler wrote: >>> Author: eadler >>> Date: Sat Jun 9 02:14:33 2018 >>> New Revision: 334864 >>> URL: https://svnweb.freebsd.org/changeset/base/334864 >>> >>> Log: >>> top(1): use a different command to toggle tid vs pid >> >> Thank you. >> >> You cannot start top with -T unless you add something like the following: > > I have a patch out for this, but svn is having issues right now (or at > least I am). > >> Another issue I just found is that if you start top with -P some columns >> don't show any values: > >> >> It is correct if you start top with -TP or -HP, or if you start top -P >> and then use H or T to switch back and forth. I'm not sure in which >> revision this was broken, it works with r333899. > > I'm guessing this is because I forgot to initalize "prehead" > somewhere. I'd like to rewrite the entire header creation, but will > try and fix this. Thanks for the report! By header, I meant header and data format string :) -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=UcWoKQeKRjWdDJ4WV9LtffsxXciv4nZzwJZpXB=YyeQ>