Date: Mon, 4 Jul 2005 11:57:33 +1200 From: Andrew Thompson <thompsa@freebsd.org> To: Mike Silbersack <silby@silby.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bridge.c Message-ID: <20050703235733.GA8138@heff.fud.org.nz> In-Reply-To: <20050703184013.U21939@odysseus.silby.com> References: <200507031824.j63IO3Bs009536@repoman.freebsd.org> <20050703184013.U21939@odysseus.silby.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 03, 2005 at 06:41:36PM -0500, Mike Silbersack wrote: > > On Sun, 3 Jul 2005, Andrew Thompson wrote: > > >thompsa 2005-07-03 18:24:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net bridge.c > > Log: > > Check the alignment of the IP header before passing the packet up to the > > packet filter. This would cause a panic on architectures that require > > strict > > alignment such as sparc64, ia64 and ppc. > > What's the route that a packet takes before it gets to the bridge? If it > goes through ether_input, it would make sense to put the alignment there > when necessary. Both bridges tap their packets off near the end of ether_input(). Since we only need to check alignment when using pfil(9) and each bridge has its own knobs to control filtering, it seems best to leave it where it is at the moment. > By the way, which network drivers are not aligning to the ip header right > now? I do not know. Maybe the originator of the PR can share what hardware he is using. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050703235733.GA8138>