Date: Mon, 01 Jun 2026 09:38:04 +0200 From: Olivier Certner <olce@freebsd.org> To: Robert Clausecker <fuz@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org> Subject: Re: git: 439710cf003b - main - assert.h: Revert "Remove leading tabs for whitespace consistency" Message-ID: <2528022.THHZn3L5Ee@ravel> In-Reply-To: <6a1c9142.3037a.348e36a2@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Hi Robert,
> As per style(9), a tab goes after #define. This should not have been
> removed.
A TAB or space indifferently can go after a '#define', the important thing is whitespace consistency. To quote style(9): "Put a single space or tab character between the #define and the macro name, but be consistent within a file.".
Here, although not covered explicitly by style(9), there's still a series of '#undef' that does not have a TAB after it but a space.
Additionally, from style(9): "The comment should be separated from the #endif or #else by a single space." speaking about comments matching (the invert of) '#if" conditions, so ruling out TABs there.
All-in-all, the original commit was fine and IMO should not have been reverted.
Thanks and regards.
--
Olivier Certner
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmodNtwACgkQjKEwQJce
JiedjQ/9HjFPytY2e+/9Dd+MKqKHS0jNMwiCdz2O5ovx2EYkzdcHv4RzCN0nYZKa
hmBWUkgv0+qWWe1tZGEnJDGv9KIecA8Empk5++mWHYmKHSl2OsXasg/tnNPhBenq
rLDsmS1HCzpmSBcG49ajTt8tHzw0yjr085S7fvD/9Bcvl5d8QzJBYdJ+FtHcm8MF
iRduU+bjpTRYANV9oWFDVKTyZavKFH1kAYWY3u6f2rE6b0Igsj4jPNfQl6uxxFkJ
aMHNmr75Iinq/Ioayj2XHM2z5ZflnO4DmvXANkS64CD1Z5SrWU1HGBz7h1zcfPsI
VHxtPQrCl53JmN6AFinrtAJ1J8YUEBXzL+zSy330njgPP6Und4/QrO8Ix2LVMo0C
n5cbnLZ0N7T69lHnaWW+XywsVyZkf2zCdhE3eBTWWUYIpOx8VYBsuHNwD5aH1nCI
Tp/YF9Vv5b+3yukCbe3Ga0/AuNyM2MPVlB4y0eFBppZ+jCfxuHAjEk1wAsVvCTm/
KP7J4fO8slovhyKmbBk0g5aRGkgrau0Ai8ZJu/xY3TJc2BlVmETtXO3McYK5Pwr9
eMDd90jIdnIpCwfn0bbvKtogI7oXMD6XZ/+zzNvv8NaOeSvUwSF5PpWqqMi7lFaC
sR8nnGsbFoUFs6thNA4/5Eiegeuv4lbX5/V9r8lHePUM6nlbXJk=
=sRUl
-----END PGP SIGNATURE-----
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2528022.THHZn3L5Ee>