Date: Tue, 26 Jun 2018 05:21:27 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: rgrimes@freebsd.org Cc: Roger Pau Monn?? <royger@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga Message-ID: <20180626052127.GA19828@FreeBSD.org> In-Reply-To: <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net> References: <201806250939.w5P9dGMA067104@repo.freebsd.org> <201806251543.w5PFhp8g099163@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote: > > New Revision: 335629 > > URL: https://svnweb.freebsd.org/changeset/base/335629 > > > > Log: > > vt: add option to ignore NO_VGA flag in ACPI > > > > To workaround buggy firmware that sets this flag when there's actually > > a VGA present. > > > > Reported and tested by: Yasuhiro KIMURA <yasu@utahime.org> > > Sponsored by: Citrix Systems R&D > > Reviewed by: kib > > Differential revision: https://reviews.freebsd.org/D16003 > > It is generally best to avoid double negatives, > couldnt this of been better named? (hw.vga.acpi_force_vga) Yes please; I get constantly confused when calculating negatives and often get them wrong. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180626052127.GA19828>