Date: Tue, 25 Apr 2017 13:33:38 -0500 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: rgrimes@freebsd.org Cc: Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r317409 - head/contrib/tcpdump Message-ID: <CAJ5_RoAgqE2gBsP1NQMQVLXjmRJC1_d3wihPVsEcmYo9HHknDw@mail.gmail.com> In-Reply-To: <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net> References: <201704251556.v3PFuk5U053547@repo.freebsd.org> <201704251830.v3PIUHdb062645@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: glebius > > Date: Tue Apr 25 15:56:46 2017 > > New Revision: 317409 > > URL: https://svnweb.freebsd.org/changeset/base/317409 > > > > Log: > > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use > after free > > Lets not use git hashes as references in commit messages, > it has very little value for someone reading a log of changes > looking for something. There is no promise that it can be > found later (github can go Poof). > On the contrary, a git SHA1 seems like an eminently stable and unique search parameter! I agree that a commit log should inline some summary of the change as well as provide a link to the external source, but I am not worried that a future reader will be unable to find the referenced commit. -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoAgqE2gBsP1NQMQVLXjmRJC1_d3wihPVsEcmYo9HHknDw>