Date: Mon, 1 Jul 2013 10:06:05 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: Peter Wemm <peter@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r252458 - head/lib/libc/iconv Message-ID: <20130701170605.GM26412@funkthat.com> In-Reply-To: <201307010806.r6186QmN027318@svn.freebsd.org> References: <201307010806.r6186QmN027318@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Wemm wrote this message on Mon, Jul 01, 2013 at 08:06 +0000:
> Initialize the pthread rwlock. Note that upstream has three
> separate locks. The file-local static lock appears intentional.
I believe that when I was tracing the lock issues, that there were
some deadlocks that can occur even w/ separate locks. I did post a
patch that made the lock a single lock and avoided the issues w/ the
lock, but as I didn't have time to test it, never committed it.
This definitely needs some real software engineering applied to it,
either put this declaration in the respective files (so that if someone
uses this is a new file, they won't get burned) and comments around
the macros that it isn't a global lock.
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130701170605.GM26412>