Date: Sat, 21 Nov 2015 09:36:11 +0200 From: Dan Partelly <dan_partelly@rdsor.ro> To: Conrad Meyer <cemeyer@uw.edu> Cc: freebsd-hackers@freebsd.org Subject: Re: libUCL / UCL as FreeBSD config question Message-ID: <BBE2B74D-104E-49A6-B780-C26635FFA23D@rdsor.ro> In-Reply-To: <20151120125846.31d4f4cc@m> References: <5B598F72-C5DD-48FD-866D-F90E117D646E@rdsor.ro> <564F6118.5030702@freebsd.org> <1448048197.2765.74.camel@michaeleichorn.com> <564F771F.4060408@freebsd.org> <20151120125846.31d4f4cc@m>
next in thread | previous in thread | raw e-mail | index | archive | help
I fully support this point of view. A short term fix is uncalled for. > On 20 Nov 2015, at 22:58, Conrad Meyer <cemeyer@uw.edu> wrote: > > On Fri, 20 Nov 2015 14:40:15 -0500 > Allan Jude <allanjude@freebsd.org> wrote: >> The issue is that UCL allows comments anywhere, for example: >> >> #above >> FreeBSD: { >> /* before */ url: >> "pkg+http://pkg.FreeBSD.org/${ABI}/latest", mirror_type: /* >> middle */ "srv", signature_type: "fingerprints", /* after */ >> # under >> fingerprints: "/root/keys/pkg", # inline-after >> enabled: yes >> } >> >> Etc. So the solution that was discussed was changing libucl >> to use an Abstract Syntax Tree, but that is a lot of work. >> So for now, I am not sure what the best approach is. > > I think an AST that keeps comments is a good approach going > forwards. We don't need a short-term fix that is anything > less than that. > > Best, > Conrad > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BBE2B74D-104E-49A6-B780-C26635FFA23D>