Date: Sun, 9 Sep 2001 15:10:06 +0100 From: Josef Karthauser <joe@tao.org.uk> To: Peter Wemm <peter@wemm.org> Cc: Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: CVSROOT cfg.pm commit_prep.pl Message-ID: <20010909151006.C69728@tao.org.uk> In-Reply-To: <20010908215254.D8BCD380A@overcee.netplex.com.au>; from peter@wemm.org on Sat, Sep 08, 2001 at 02:52:54PM -0700 References: <200109080211.f882BZt86733@freefall.freebsd.org> <20010908215254.D8BCD380A@overcee.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, Sep 08, 2001 at 02:52:54PM -0700, Peter Wemm wrote: > Josef Karthauser wrote: > > joe 2001/09/07 19:11:35 PDT > > > > Modified files: > > . cfg.pm commit_prep.pl > > Log: > > Add code to unexpand $FreeBSD: xxxx $ (or whatever is defined in > > the config file as being our $IDHEADER$) upon commit. This is useful > > to avoid a '+1 -1' delta against the version string. > > This is broken, it happens before the $Id$ spamming checks. You only > want this to be run after all the sanity checks are done. Of course then > you have to fix all the return's from the function. :-) You mean that it happens before the spamming checks have had a chance to complain? I was so worried about making sure that this worked for remote commits I forgot that it probably modifies the file directly when committing locally. I'll fix this. > In fact, it should probably go after the &check_version() call, not > inside check_version itself. Except that it probably shouldn't touch files that are "excluded" right? They're excluded for a reason. I'll separate this out to make it easier to handle. Regards, Joe [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjubeD0ACgkQXVIcjOaxUBY4jQCgp2WP59GuT5/dzjrHx1hxUudz n8oAoJgu9yNaKv7yE/PgoXfNdIyoq3PB =VftB -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010909151006.C69728>