Date: Fri, 18 Jul 2008 09:31:13 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Andrew Thompson <thompsa@FreeBSD.org> Cc: current@FreeBSD.org, Pyun YongHyeon <yongari@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/age if_age.c if_agereg.h if_agevar.h Message-ID: <20080718003112.GA52865@cdnetworks.co.kr> In-Reply-To: <20080717235630.GL33414@citylink.fud.org.nz> References: <200805190140.m4J1e0YW001168@repoman.freebsd.org> <20080717235630.GL33414@citylink.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 17, 2008 at 04:56:30PM -0700, Andrew Thompson wrote:
> On Mon, May 19, 2008 at 01:39:59AM +0000, Pyun YongHyeon wrote:
> > yongari 2008-05-19 01:39:59 UTC
> >
> > FreeBSD src repository
> >
> > Added files:
> > sys/dev/age if_age.c if_agereg.h if_agevar.h
> > Log:
> > Add age(4), a driver for Attansic/Atheros L1 gigabit ethernet
> > controller.
>
> +static void
> +age_phy_reset(struct age_softc *sc)
> +{
> +
> + /* Reset PHY. */
> + CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_RST);
> + pause("agephy", hz / 1000);
> + CSR_WRITE_4(sc, AGE_GPHY_CTRL, GPHY_CTRL_CLR);
> + pause("agephy", hz / 1000);
> +}
>
> This will panic if hz < 1000, perhaps a DELAY(1) is better?
Ah, yes. I'll fix that. Thanks a lot!
>
>
> Andrew
--
Regards,
Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080718003112.GA52865>