Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Feb 2013 07:39:57 -0500
From:      Alfred Perlstein <bright@mu.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        net@FreeBSD.org
Subject:   Re: m_get2() name
Message-ID:  <510BB79D.8040707@mu.org>
In-Reply-To: <20130201120414.GG91075@FreeBSD.org>
References:  <20130201120414.GG91075@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2/1/13 7:04 AM, Gleb Smirnoff wrote:
>    Hi!
>
>    The m_get2() function allocates a single mbuf with enough space
> to hold specified amount of data. It can return either a single mbuf,
> an mbuf with a standard cluster, page size cluster, or jumbo cluster.
>
>    It is alredy utilized in pfsync, bpf, libalias and soon to be utilized
> in ieee802111. There are probably more places in stack where it can be used.
>
>    The question is about its name. Once introduced, I just gave it name
> "m_get2" to avoid discussion with myself about bikeshed colour and continue
> hacking. Now it is getting used wider, and before we branch any stable branch
> off the head, we have last chance to rename it to smth more meaningful.
>
>    Any ideas on better name are welcome.
>
m_getbs - mbuf get buffer size.

conveniently also maps to:

m_getbs - mbuf get bike shed.

This is a cool function.  Maybe it should take an int*error arg as well 
for ENOBUFS/EINVAL?

-Alfred



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?510BB79D.8040707>