Date: Sat, 20 Dec 1997 13:57:16 +1030 From: Greg Lehey <grog@lemis.com> To: Julian Elischer <julian@whistle.com> Cc: Bruce Evans <bde@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: Bruce vandalism again Message-ID: <19971220135716.14528@lemis.com> In-Reply-To: <349B1196.167EB0E7@whistle.com>; from Julian Elischer on Fri, Dec 19, 1997 at 04:30:14PM -0800 References: <199712200007.QAA04713@freefall.freebsd.org> <349B1196.167EB0E7@whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 19, 1997 at 04:30:14PM -0800, Julian Elischer wrote:
> Bruce Evans wrote:
> >
> > bde 1997/12/19 16:07:12 PST
> >
> > Modified files:
> > sys/net if_ethersubr.c
> > sys/netinet if_ether.c
> > Log:
> > Fixed gratuitous ANSIisms.
> >
> > Revision Changes Path
> > 1.41 +5 -2 src/sys/net/if_ethersubr.c
> > 1.42 +2 -2 src/sys/netinet/if_ether.c
> Bruce.
>
> I know this has been discussed before,
> but I'm not convinced that you are mving with the agreement of
> everybody here.
>
> int
> -ether_ioctl(struct ifnet *ifp, int command, caddr_t data)
> +ether_ioctl(ifp, command, data)
> + struct ifnet *ifp;
> + int command;
> + caddr_t data;
> {
> struct ifaddr *ifa = (struct ifaddr *) data;
>
> I know I am converting every function I add and anything I massively
> rewrite to use prototypes.
> I know I have a lot of people on my side here.
> a commit that does nothing but this vandalism is REALLY ANNOYING!
I agree. This appears to be a seriously retrograde step. Bruce, why?
Greg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19971220135716.14528>