Date: Mon, 3 Aug 2015 14:24:44 +0000 From: Steve Wills <swills@FreeBSD.org> To: Torsten Zuehlsdorff <info@toco-domains.de> Cc: ruby@freebsd.org Subject: Re: [Gitlab] Current Status of the port Message-ID: <20150803142440.GA23813@mouf.net> In-Reply-To: <55BF265B.9090401@toco-domains.de> References: <55BA3B55.5010000@toco-domains.de> <20150730152241.GC82229@mouf.net> <55BA4532.40107@toco-domains.de> <20150731135045.GA49801@mouf.net> <55BB8272.3060900@toco-domains.de> <20150731143935.GC49801@mouf.net> <55BB8B17.7050509@toco-domains.de> <20150731174219.GD49801@mouf.net> <55BF265B.9090401@toco-domains.de>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Aug 03, 2015 at 10:29:15AM +0200, Torsten Zuehlsdorff wrote:
> Hello,
>
> >> # cd /usr/ports/devel/rubygem-gitlab_git-rails41
> >> # portlint -AC
> >> FATAL: Makefile: the last line of a slave port's Makefile has to be
> >> .include "${MASTERDIR}/Makefile"
> >> FATAL: Makefile: extra item "MASTERDIR" placed in the PORTNAME section.
> >> FATAL: Makefile: extra item "PKGNAMESUFFIX" placed in the LICENSE section.
> >> WARN: Consider to set DEVELOPER=yes in /etc/make.conf
> >> 3 fatal errors and 1 warning found.
> >
> > portlint doesn't really fully grok slave ports, unless I'm mistaken, so use
> > your judgement here, but the include does need to be last.
>
> Okay, will fix.
>
> >> When including the Master-Makefile in the last line, the PKGNAMESUFFIX
> >> for example is not used.
> >
> > Change the master port to use ?= instead of = for the things you want to override.
That's no problem.
> This works, but increases the number of changed ports ;)
>
> Also it just remove one FATAL error. This other 2 persists. Is this
> enough or should i do further research?
In slave ports only, it's OK IMHO to ignore the issues from portlint about
ordering.
Steve
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQF8BAEBCgBmBQJVv3miXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ5OEZBNDE0QTVDMkEwRUY5Q0ZEMEFEMERG
NUNGNjJCMzIwN0IxQkExAAoJEPXPYrMgexuhY6EH/1C3DxfOYNPMU1ln0Rtc6d0k
qZ+Wzy1y87wZBz98xGD/+CgsyXvq17gcVaweYfeTFZjwMjvBM2S9tJ0i1XugWs6h
cWJnMNXX74AyLHR5aqqYMtA3mpanGh/ksS13r3AytRQtl4iYrcuhtw2SvMFxxbbd
6IkJWMGtAK5qCzhE4JUOTlt5mK0vlChUceNkTZlCLnCIVBtQQL24x+K2gAtUyDS0
ZvF7Fy2/6fHoJDnJeUWyp4EBbQP+em5WeMKGLDs30Pvyo14GiK8FSJH9s4lMyuXC
BlePMY4RyO1GYUz7YuTjDOtxGIgBSU+42qZUrswKHG+f3uGp5JuI2gcc+0fe2vU=
=8GMu
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150803142440.GA23813>