Date: Mon, 3 Sep 2012 17:51:53 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r240060 - in head: include/rpc sys/rpc Message-ID: <1346719913.68772.YahooMailNeo@web113520.mail.gq1.yahoo.com> In-Reply-To: <20120903144050.GN33100@deviant.kiev.zoral.com.ua> References: <20120903073133.GB33100@deviant.kiev.zoral.com.ua> <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com> <20120903144050.GN33100@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
...=0A>________________________________=0A>=0A>From: Konstantin Belousov=0A=
>=A0=0A>...=0A>=0A>>=A0 =0A>> PR 137443=0A>From the PR, I fail to see what =
is the problem in our headers, and why=0A>the issue is not in some third-pa=
rty C++ code.=0A>=0A>It is definitely has nothing to do with C++ name mangl=
ing.=0A>=0A=A0=0AHmm.. yes, not a mangling issue but it is rather weird tha=
t it happens on C++.=0ASalome is not a toy app.=0A=0A>> =0A>> > Although no=
t very useful due to many other namespace=0A>> > pollution problems=0A>> > =
in the rpc headers, __rpc_xdr is in the=0A>> > implementation-reserved name=
space,=0A>> > while XDR is not.=0A>> > =0A>> =0A>> The forced reference her=
e is {Open}Solaris:=0A>> =0A>> http://src.illumos.org/source/xref/illumos-g=
ate/usr/src/uts/common/rpc/xdr.h=0A>> =0A>> OpenGrok found no reference to =
__rpc_xdr=0A>> in OpenSolaris/illumos.=0A>I see, Solaris does=0A>=A0=A0=A0 =
typedef struct XDR { ... } XDR;=0A>and we now use the same trick.=0A>=0A>So=
my objections, if any, were against the commit message and not the actual=
=0A>code change then.=0A>=0A=A0=0AQuite definitely :(=A0.. I mixed two diff=
erent issues that I was trying to solve=0A(and one of them was not an issue=
at all). I will do a better job when I=0AMFC.=0A=A0=0AThanks for checking =
though: I do feel nervous when touching a standard=0Aheader=A0even if it's =
just to follow a change from upstream!=0A=A0=0A=A0=0APedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1346719913.68772.YahooMailNeo>