Date: Mon, 3 Sep 2012 17:51:53 -0700 (PDT) From: Pedro Giffuni <pfg@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r240060 - in head: include/rpc sys/rpc Message-ID: <1346719913.68772.YahooMailNeo@web113520.mail.gq1.yahoo.com> In-Reply-To: <20120903144050.GN33100@deviant.kiev.zoral.com.ua> References: <20120903073133.GB33100@deviant.kiev.zoral.com.ua> <1346681599.92069.YahooMailClassic@web113502.mail.gq1.yahoo.com> <20120903144050.GN33100@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
...
>________________________________
>
>From: Konstantin Belousov
>
>...
>
>>
>> PR 137443
>From the PR, I fail to see what is the problem in our headers, and why
>the issue is not in some third-party C++ code.
>
>It is definitely has nothing to do with C++ name mangling.
>
Hmm.. yes, not a mangling issue but it is rather weird that it happens on C++.
Salome is not a toy app.
>>
>> > Although not very useful due to many other namespace
>> > pollution problems
>> > in the rpc headers, __rpc_xdr is in the
>> > implementation-reserved namespace,
>> > while XDR is not.
>> >
>>
>> The forced reference here is {Open}Solaris:
>>
>> http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/rpc/xdr.h
>>
>> OpenGrok found no reference to __rpc_xdr
>> in OpenSolaris/illumos.
>I see, Solaris does
> typedef struct XDR { ... } XDR;
>and we now use the same trick.
>
>So my objections, if any, were against the commit message and not the actual
>code change then.
>
Quite definitely :( .. I mixed two different issues that I was trying to solve
(and one of them was not an issue at all). I will do a better job when I
MFC.
Thanks for checking though: I do feel nervous when touching a standard
header even if it's just to follow a change from upstream!
Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1346719913.68772.YahooMailNeo>