Date: Tue, 26 Feb 2008 13:57:09 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Kris Kennaway <kris@FreeBSD.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, "David E. O'Brien" <obrien@FreeBSD.org> Subject: Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vnode_if.src src/sys/sys mount.h vnode.h Message-ID: <86r6ezswnu.fsf@ds4.des.no> In-Reply-To: <20080226123107.N90776@fledge.watson.org> (Robert Watson's message of "Tue\, 26 Feb 2008 12\:33\:31 %2B0000 \(GMT\)") References: <200802250855.m1P8t3w6052042@repoman.freebsd.org> <47C29A07.2070908@FreeBSD.org> <86d4qli8a1.fsf@ds4.des.no> <20080226123107.N90776@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson <rwatson@FreeBSD.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > No, it changes neither the API nor the ABI. It replaces caddr_t > > (which is typedef'd to char *) with void *, and those two are > > compatible types. > I'm sorry, but I disagree. The case you failed to test involves a > function pointer typedef. Umm, OK, I didn't spot that. It's unfortunate that David didn't change our own file system code to match (or even build LINT, which would have shown him the problem), so that RELENG_6 current doesn't build. Still, I would argue for fixing the code rather than reverting the change. > Here's the test I had to add to Arla to detect the change with > autoconf; without this autoconf mess and changed prototypes in the > Arla nnpfs code, I can't build nnpfs on -CURRENT, and presumably now > also on our -STABLE branches: Arguably, Arla has been broken for more than two years and you only just woke up and noticed. If you had tried to build Arla on -CURRENT at any point since 2005/12/14, you would have noticed and presumably fixed it. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86r6ezswnu.fsf>