Date: Fri, 17 May 2019 15:36:37 +1000 From: Peter Jeremy <peter@rulingia.com> To: Tycho Nightingale <tychon@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347890 - in head/sys/dev: aac bge Message-ID: <20190517053637.GH98005@server.rulingia.com> In-Reply-To: <201905162041.x4GKfTwb013353@repo.freebsd.org> References: <201905162041.x4GKfTwb013353@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--y2zxS2PfCDLh6JVG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-May-16 20:41:29 +0000, Tycho Nightingale <tychon@FreeBSD.org> wrote: >Author: tychon >Date: Thu May 16 20:41:28 2019 >New Revision: 347890 >URL: https://svnweb.freebsd.org/changeset/base/347890 > >Log: > reinstate 4GB DMA boundary workarounds for bge and aac > =20 > Reviewed by: kib > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D20277 My main concern with this commit is that there is nothing in the commit message explaining why this has been done. D20277 implies that this is effectively reverting a couple of other commits because these devices have 64-bit issues - the commit log should document this. --=20 Peter Jeremy --y2zxS2PfCDLh6JVG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAlzeSGVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzRzog/8Cg+cvNpjnPYLbFbT3ro51bD8i/ALMOBEhjdraAZS13cANPD6d6bQa09O LhzEaF1XTvkEHtFq/TFwEJvV+mvdj8RD2aHCSVFy+aftABM7mvumoV7ftMTOlzGY xZn99dJZMLyywUNb3hSNoQGaeBoZ4SPFjI4OZewbsdZbgExsMCp3K08Stowbnxzi /yPdqUyEJaNdIy6+wlqX1C7WQbynLZ4eCZLZbwLvGLZuTqWC94FxMCMXldcYod3E U+zCESbrZWQenlz/1XLV9uOqpSeajuj2LRepLf8NAQSBFm9wpiQLutWFXYW52QFi wXkAptFvuCJkyG+uytroocIRnk3RPaAByNo1jI3Yk8/D0cSrO2S+oaKi5kGltwp8 tqm0Fa5/qjC9VIV3qZOBvQc+HJTtmzQdky7uJPKSbF3RakAr8OPT60OxLw2+cYFd cdGi+00kJCxd1R+l+hUZD5+tfx3bXAxQfPNkj2fSvAhC1yqLg2ULzfoExR0cdUs1 Y0evo2QC43xzjU38e/QGfXkVv8jNTSXPr6Dk7AuXq/W+xVlLHMSdxXPI5zSLcSgy tLO6hzzj2H0RROX/XNGkZVA+6A3OJNxKOeaH9t4RpOQCoJiyPqrKaf9jaaeZ+D9V 7lT3KT1j9P5EOCyvOYSYjN/qpMaNJZWbeUJfTKy+aPWVmp33ioQ= =T2CM -----END PGP SIGNATURE----- --y2zxS2PfCDLh6JVG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190517053637.GH98005>