Date: Wed, 28 Jul 2021 00:09:26 GMT From: Ed Maste <emaste@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 941650aae976 - main - vnic: add TODO list item for non-promisc mode Message-ID: <202107280009.16S09Q8P060281@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=941650aae9762293f4c63788ddb17e0114828813 commit 941650aae9762293f4c63788ddb17e0114828813 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2021-07-27 21:51:21 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2021-07-28 00:09:01 +0000 vnic: add TODO list item for non-promisc mode Also drop ARM64TODO comments; this is an issue with this specific driver, not a general arm64 issue. PR: 223575 --- sys/dev/vnic/nic_main.c | 11 +++++++++++ sys/dev/vnic/nicvf_main.c | 6 ++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/sys/dev/vnic/nic_main.c b/sys/dev/vnic/nic_main.c index 8e6aa60f6ca8..1bc07b0291ea 100644 --- a/sys/dev/vnic/nic_main.c +++ b/sys/dev/vnic/nic_main.c @@ -27,6 +27,17 @@ * */ +/* + * Marvell/Cavium ThunderX vnic/bgx network controller + * + * UNIMPLEMENTED FEATURES + * ---------------------- + * A number of features supported by the hardware are not yet implemented in + * this driver: + * + * - PR223575 non-promiscuous mode (driver currently forces promisc) + */ + #include <sys/cdefs.h> __FBSDID("$FreeBSD$"); diff --git a/sys/dev/vnic/nicvf_main.c b/sys/dev/vnic/nicvf_main.c index c8b088dee1fa..73591a0b161a 100644 --- a/sys/dev/vnic/nicvf_main.c +++ b/sys/dev/vnic/nicvf_main.c @@ -485,16 +485,14 @@ nicvf_if_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) { if ((flags ^ nic->if_flags) & IFF_PROMISC) { /* Change promiscous mode */ -#if 0 - /* ARM64TODO */ +#if 0 /* XXX* / nicvf_set_promiscous(nic); #endif } if ((flags ^ nic->if_flags) & IFF_ALLMULTI) { /* Change multicasting settings */ -#if 0 - /* ARM64TODO */ +#if 0 /* XXX */ nicvf_set_multicast(nic); #endif }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202107280009.16S09Q8P060281>