Date: Sun, 5 Sep 2004 22:29:54 -0700 From: Luigi Rizzo <luigi@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: net@freebsd.org Subject: Re: bridge callbacks in if_ed.c? Message-ID: <20040905222954.A26501@xorpc.icir.org> In-Reply-To: <20040905230100.GA82214@cell.sick.ru>; from glebius@freebsd.org on Mon, Sep 06, 2004 at 03:01:00AM %2B0400 References: <20040905205249.GA81337@cell.sick.ru> <20040905142036.A23213@xorpc.icir.org> <20040905230100.GA82214@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 06, 2004 at 03:01:00AM +0400, Gleb Smirnoff wrote:
...
> L> I'd rather not apply the patch unless you can show that
> L> the current code leads to incorrect behaviour.
>
> I suspect that packets dropped by bridge_in() called from if_ed will
> not be captured by bpf(4). This is incorrect.
if you read the code you see that the bpf behaviour is
as it should be, and your suspect is unfounded.
- if (!ifp->if_bpf && BDG_ACTIVE( (ifp) ) ) {
(my summary and pov on the discussion in a separate email)
cheers
luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040905222954.A26501>