Date: Fri, 19 Dec 1997 21:50:30 -0800 From: John-Mark Gurney <gurney_j@efn.org> To: Greg Lehey <grog@lemis.com> Cc: Julian Elischer <julian@whistle.com>, Bruce Evans <bde@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: Bruce vandalism again Message-ID: <19971219215030.56082@hydrogen.nike.efn.org> In-Reply-To: <19971220135716.14528@lemis.com>; from Greg Lehey on Sat, Dec 20, 1997 at 01:57:16PM %2B1030 References: <199712200007.QAA04713@freefall.freebsd.org> <349B1196.167EB0E7@whistle.com> <19971220135716.14528@lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg Lehey scribbled this message on Dec 20:
> On Fri, Dec 19, 1997 at 04:30:14PM -0800, Julian Elischer wrote:
> > > Modified files:
> > > sys/net if_ethersubr.c
> > > sys/netinet if_ether.c
> > > Log:
> > > Fixed gratuitous ANSIisms.
> > >
> > > Revision Changes Path
> > > 1.41 +5 -2 src/sys/net/if_ethersubr.c
> > > 1.42 +2 -2 src/sys/netinet/if_ether.c
> > Bruce.
> >
> > I know this has been discussed before,
> > but I'm not convinced that you are mving with the agreement of
> > everybody here.
> >
> > int
> > -ether_ioctl(struct ifnet *ifp, int command, caddr_t data)
> > +ether_ioctl(ifp, command, data)
> > + struct ifnet *ifp;
> > + int command;
> > + caddr_t data;
> > {
> > struct ifaddr *ifa = (struct ifaddr *) data;
> >
> > I know I am converting every function I add and anything I massively
> > rewrite to use prototypes.
> > I know I have a lot of people on my side here.
> > a commit that does nothing but this vandalism is REALLY ANNOYING!
>
> I agree. This appears to be a seriously retrograde step. Bruce, why?
easy, don't you guys read style(9)?
Use of the __P macro in new code is discouraged, although modifications
to existing files should be consistent with that file's conventions.
all the other parts of the code in that file are K&R style... so you
need to maintain that convention...
--
John-Mark Gurney Modem/FAX: +1 541 683 6954
Cu Networking P.O. Box 5693, 97405
Live in Peace, destroy Micro$oft, support free software, run FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19971219215030.56082>