Date: Tue, 20 Feb 2018 19:22:51 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 198385] syslogd seems to leak memory under certain circumstances Message-ID: <bug-198385-8-VrRtviK8kX@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-198385-8@https.bugs.freebsd.org/bugzilla/> References: <bug-198385-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198385 David Bright <dab@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dab@freebsd.org Status|New |Open --- Comment #2 from David Bright <dab@freebsd.org> --- Sreeram, please let me know if you are still interested in pursuing a fix to this bug. I can help you with that if so. One change I would suggest in your proposed patch is to exchange the order of the F_FILE and F_FORW cases so that the clean up applicable to F_FORW is not also done for the F_FILE case. Granted, the "if (f->f_un.f_forw.f_addr)" test would (should) fail in the F_FILE case, but it would still be cleaner not to attempt it at all. Also, it would be very helpful if you could rebase your patch on the current HEAD branch, which is where it would first be integrated into the FreeBSD code base. If you do not want to pursue this fix, I will do so myself, based on the information you have provided so far. Thank you. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-198385-8-VrRtviK8kX>