Date: Sun, 12 Sep 2004 19:34:26 +0200 (CEST) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71659: [PATCH] cleanup of the usr.sbin/mount_portalfs code Message-ID: <200409121734.i8CHYQK1010896@kulesh.obluda.cz> Resent-Message-ID: <200409121740.i8CHeNir009005@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71659
>Category: bin
>Synopsis: [PATCH] cleanup of the usr.sbin/mount_portalfs code
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Sep 12 17:40:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
usr.sbin/mount_portalfs/pt_tcplisten.c,v 1.4 2004/08/07 04:27:50 imp
>Description:
There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.
Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.
I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.
usr.sbin/mount_portalfs/pt_tcplisten.c:83: warning: 'ipp' might be used uninitialized in this function
>How-To-Repeat:
N/A
>Fix:
*** usr.sbin/mount_portalfs/pt_tcplisten.c.ORIG Sun Aug 8 21:13:25 2004
--- usr.sbin/mount_portalfs/pt_tcplisten.c Sun Sep 12 04:49:09 2004
***************
*** 80,86 ****
char *q;
struct hostent *hp;
struct servent *sp;
! struct in_addr **ipp;
struct in_addr *ip[2];
struct in_addr ina;
u_short s_port;
--- 80,86 ----
char *q;
struct hostent *hp;
struct servent *sp;
! struct in_addr **ipp = ipp; /* "init" to avoid "might be used uninitialised" warning */
struct in_addr *ip[2];
struct in_addr ina;
u_short s_port;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409121734.i8CHYQK1010896>