Date: Mon, 20 Mar 2006 15:30:37 -0500 From: John Baldwin <jhb@freebsd.org> To: "Christian S.J. Peron" <csjp@freebsd.org> Cc: Todd Miller <millert@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 93645 for review Message-ID: <200603201530.41496.jhb@freebsd.org> In-Reply-To: <441F0B39.3000406@FreeBSD.org> References: <200603201752.k2KHqO5h027598@repoman.freebsd.org> <441F0B39.3000406@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 20 March 2006 15:06, Christian S.J. Peron wrote: > Todd Miller wrote: > > >http://perforce.freebsd.org/chv.cgi?CH=93645 > > > >Change 93645 by millert@millert_p3 on 2006/03/20 17:51:24 > > > > Arg pointer in mac_thread_syscall_{enter,exit} should be > > register_t * not int *. Fixes compilation problem on amd64. > > > >Affected files ... > > > >.. //depot/projects/trustedbsd/sebsd/sys/security/mac/mac_system.c#10 edit > > > >Differences ... > > > >==== //depot/projects/trustedbsd/sebsd/sys/security/mac/mac_system.c#10 (text+ko) ==== > > > >@@ -282,7 +282,7 @@ > > } > > > > int > >-mac_thread_syscall_enter(struct thread *td, int *args, int code) > >+mac_thread_syscall_enter(struct thread *td, register_t *args, int code) > > { > > int error; > > > >@@ -293,7 +293,7 @@ > > } > > > > void > >-mac_thread_syscall_exit(struct thread *td, int *args, int code, int errcode) > >+mac_thread_syscall_exit(struct thread *td, register_t *args, int code, int errcode) > > { > > > > if (!mac_enforce_syscall) > > > > > > > > > Does this still build on i386? Probably, register_t == int on i386. This is the right change though, syscall arguments are typically passed in registers and/or on the stack, and stack values should fit in registers. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603201530.41496.jhb>