Date: Mon, 21 Dec 2020 10:33:48 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, freebsd-git <freebsd-git@freebsd.org> Subject: Re: Git commit message templates Message-ID: <CANCZdfo_CHu83nTJ%2BCT4S_-dKg%2BywtYoxi6RQaARq2FPGeXsWg@mail.gmail.com> In-Reply-To: <5398f806-42a5-560e-a22c-c5483a0c6f9e@FreeBSD.org> References: <CAPyFy2DveYMw6VyxT8QwOCNreHTyi6RoYX1EWEfysMEqCpcjZQ@mail.gmail.com> <c18f71b2-8356-c1ad-b0d7-9b742f2d9fb9@FreeBSD.org> <CAPyFy2CGKgvjmAsFtVwBsuPaR6p6QF5X659fU9VFB%2Bf_N7vosg@mail.gmail.com> <5398f806-42a5-560e-a22c-c5483a0c6f9e@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 21, 2020 at 10:28 AM John Baldwin <jhb@freebsd.org> wrote: > On 12/17/20 12:58 PM, Ed Maste wrote: > > On Wed, 16 Dec 2020 at 17:35, John Baldwin <jhb@freebsd.org> wrote: > >> > >> The only one I'm not a fan of is the lack of punctuation for the first > >> sentence. Newspaper headlines also use additional capitalization > >> (e.g. last word and "significant words"), so the current recommendation > >> is a mix of things and not fully consistent with either one. > > > > Fair point - considering the first line as one would an email subject > > is probably the best approach. > > I agree. Perhaps just say that (rather than newspaper headline) and leave > off the note about punctuation. > Personally, I think we're starting to get a bit over prescriptive here. Once you have the length down, and have a keyword at the start, you've got 99% of the benefit. Nobody cares if there's a dot at the end or not, and it's presence or absence adds no value to other readers. Nobody cares about having lots of caps or not. We should just let people use their judgement. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo_CHu83nTJ%2BCT4S_-dKg%2BywtYoxi6RQaARq2FPGeXsWg>