Date: Mon, 23 Aug 2010 22:54:41 -0400 From: Michael Butler <imb@protected-networks.net> To: Kostik Belousov <kostikbel@gmail.com> Cc: Peter Holm <pho@freebsd.org>, Jeff Roberson <jroberson@jroberson.net>, current@freebsd.org Subject: Re: softupdate with journal panic Message-ID: <4C733471.3000202@protected-networks.net> In-Reply-To: <20100823211257.GI2396@deviant.kiev.zoral.com.ua> References: <4C7011B9.4020902@protected-networks.net> <20100822132104.GA7300@x2.osted.lan> <20100823211257.GI2396@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 08/23/10 17:12, Kostik Belousov wrote: > On Sun, Aug 22, 2010 at 03:21:04PM +0200, Peter Holm wrote: >> On Sat, Aug 21, 2010 at 01:49:45PM -0400, Michael Butler wrote: >>> While updating sysutils/coreutils port on -current as of this morning >>> (SVN r211550), I noted a panic during the directory rename config test. >>> >> >> Your problem seems identical to this report: >> >> http://docs.freebsd.org/cgi/mid.cgi?AANLkTinPjiOV21kDLZYV5WScrhLMN7DY8E8jVHWPU5mC >> > I believe that dotdotremref in this case is legitimately NULL. With this > assumption, the following patch would help. Confirmed - with the patch below, it works as expected; thanks! imb > > diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c > index b666c0f..65e5255 100644 > --- a/sys/ufs/ffs/ffs_softdep.c > +++ b/sys/ufs/ffs/ffs_softdep.c > @@ -6770,7 +6794,8 @@ cancel_diradd(dap, dirrem, jremref, dotremref, dotdotremref) > mkdir->md_jaddref = NULL; > if (mkdir->md_state & MKDIR_PARENT) { > if (cancel_jaddref(jaddref, NULL, > - &dirrem->dm_jwork) == 0) { > + &dirrem->dm_jwork) == 0 && > + dotdotremref != NULL) { > free_jremref(dotdotremref); > dotdotremref = NULL; > }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C733471.3000202>