Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Dec 2005 01:36:26 -0800
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Florent Thoumie <flz@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org>
Subject:   Re: cvs commit: ports/shells/bash Makefile
Message-ID:  <20051205093626.GA68544@dragon.NUXI.org>
In-Reply-To: <1133380999.1219.30.camel@cream.xbsd.org>
References:  <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote:
> Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit :
> > On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote:
> > > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??crit :
> > > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote:
> > > > > flz         2005-11-30 15:10:12 UTC
> > > > > 
> > > > >   FreeBSD ports repository
> > > > > 
> > > > >   Modified files:
> > > > >     shells/bash          Makefile 
> > > > >   Log:
> > > > >   - Add WANT_STATIC_BASH knob.
> > > > 
> > > > WANT_ prefix belongs to bpm's internal namespace; it should not be used
> > > > this way.
> > > 
> > > 	Agreed, Pav made the same notice but :
> > > 
> > > 	1) that's not my port and,
> > 
> > Don't commit bogus changes, and
> > 
> > > 	2) shells/bash2 has the same exact construction.
> > 
> > fix bogus changes when you encounter them.
> 
> 	I'll send a PR with s/WANT/WITH/ later and will commit the fix
> 	in two weeks with maintainer timeout.

*sigh* why all the overhead?  Since you're already in the middle of this
issue, please make it right for our users and just commit the fixed
version now.
 
-- 
-- David  (obrien@FreeBSD.org)
Q: Because it reverses the logical flow of conversation.
A: Why is top-posting (putting a reply at the top of the message) frowned upon?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051205093626.GA68544>