Date: Fri, 31 Aug 2012 19:05:53 -0400 From: Trent Nelson <trent@snakebite.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: "freebsd-fs@FreeBSD.org" <freebsd-fs@FreeBSD.org> Subject: Re: chmod -h 000x against symlink has bizarre results on ZFS Message-ID: <20120831230553.GC59852@snakebite.org> In-Reply-To: <503CDD4E.6050902@FreeBSD.org> References: <20120824011517.GJ42732@snakebite.org> <503CD4F1.6060001@FreeBSD.org> <503CDD4E.6050902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Aug 28, 2012 at 08:01:34AM -0700, Andriy Gapon wrote:
> on 28/08/2012 17:25 Andriy Gapon said the following:
> Will you be able to test the following patch?
> Preferably on a temporary test pool - I don't want to risk your data.
>
> diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> index 69374fb..7f61517 100644
> --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c
> @@ -1695,6 +1695,7 @@ sa_modify_attrs(sa_handle_t *hdl, sa_attr_type_t newattr,
> ASSERT(action == SA_REPLACE);
> SA_ADD_BULK_ATTR(attr_desc, j, attr,
> locator, datastart, buflen);
> + length_idx++;
> } else {
> length = SA_REGISTERED_LEN(sa, attr);
> if (length == 0) {
>
That looks like it did the trick. Nice one :-)
What's the protocol for ZFS bugfixes? I'm happy to do the leg work
(submitting PRs to other teams etc).
> Andriy Gapon
Trent.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120831230553.GC59852>