Date: Sun, 26 Jun 2016 19:09:06 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Benjamin Kaduk <bjkfbsd@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r302210 - head/sys/fs/nfsclient Message-ID: <20160626160906.GC38613@kib.kiev.ua> In-Reply-To: <CAJ5_RoB%2Bz6%2BHBUd1Hzp38o1QP3uo8UNNwT319af%2B5dVGw8NSaw@mail.gmail.com> References: <201606261418.u5QEITxu002962@repo.freebsd.org> <CAJ5_RoB%2Bz6%2BHBUd1Hzp38o1QP3uo8UNNwT319af%2B5dVGw8NSaw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Sun, Jun 26, 2016 at 10:54:44AM -0500, Benjamin Kaduk wrote: > On Sun, Jun 26, 2016 at 9:18 AM, Konstantin Belousov <kib@freebsd.org> > wrote: > > > Author: kib > > Date: Sun Jun 26 14:18:28 2016 > > New Revision: 302210 > > URL: https://svnweb.freebsd.org/changeset/base/302210 > > > > Log: > > Clean other flags in ncl_inactive, only. Add comment explaining why > > other > > flags should be unset. > > > [...] > > > + > > + /* > > + * NMODIFIED means that there might be dirty/stale buffers > > + * associated with the NFS vnode. None of the other flags are > > + * meaningful after the vnode is unused. > > + */ > > + np->n_flag &= NMODIFIED; > > > > Maybe I am confused, but the commit message reads like this should be '=', > not '&='. The line clears all flags except NMODIFIED, and lefts the NMODIFIED flag intact (it could have been not set there, after all).home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160626160906.GC38613>