Date: Wed, 16 Aug 2023 11:57:32 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273148] [PATCH] scripted installs are unable to verify checksums for fetched dists Message-ID: <bug-273148-227-aSSTVpQXT0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-273148-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273148 --- Comment #3 from Lars Kellogg-Stedman <lars@oddbit.com> --- > Have you read the commit message... Of course...and then I read the code, which is logically incorrect, syntactically incorrect, obviously never tested, and breaks a major existing piece of functionality. It should never have been accepted in the first place. The commit also looks like only a partial attempt at a solution, because it doesn't touch the identical code in the "auto" script (nor the several additional places in "auto" that perform the same fd manipulation). I think reverting the original commit is absolutely the best course of action because it restores the ability to perform fully automated installs. If the commit was solving a real problem, we can take the time to develop a more effective solution once we have un-broken this critical feature. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273148-227-aSSTVpQXT0>