Date: Mon, 10 Sep 2007 03:38:54 -0400 From: Daniel Rucci <dan@rucci.org> To: Greg Lewis <glewis@eyesbeyond.com> Cc: freebsd-eclipse@freebsd.org Subject: Re: eclipse 3.3.0 Message-ID: <46E4F48E.2090904@rucci.org> In-Reply-To: <20070909191227.GA12241@misty.eyesbeyond.com> References: <46E308C1.8040501@buzmo.com> <20070909.114656.104027741.ken@tydfam.jp> <46E38E90.5090606@buzmo.com> <20070909.183337.115905635.ken@tydfam.jp> <46E413CE.5050209@buzmo.com> <20070909191227.GA12241@misty.eyesbeyond.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg Lewis wrote:
> On Sun, Sep 09, 2007 at 08:39:58AM -0700, Mike Bowie wrote:
>> Ken Yamada wrote:
>>> Opps!
>>>
>>> You missed ${WRKSRC} in ${CP}.
>>> It needs to be ;
>>>
>>> do-build:
>>> @(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} \
>>> ./build -os ${ECLIPSE_OS} -ws ${ECLIPSE_WS} -arch ${ECLIPSE_ARCH}
>>> -comp
>>> ilelibs)
>>> @${CP}
>>> ${WRKSRC}/launchertmp/library/${ECLIPSE_WS}/eclipse_1017a.so \
>>> ${WRKSRC}/eclipse/plugins/org.eclipse.equinox.launcher.${ECLIPSE_WS}.${ECLIPSE_OS}.${ECLIPSE_ARCH}_1.0.0.v20070606
>>>
>>> Yes, it works - better than I thought..., but, we may better tailor
>>> build.xml further before committing as a port so that we can port next
>>> version easier...
>> Ah yes! That's what I get for rushing through!
>>
>> http://www.buzmo.com/projects/eclipse-europa-port/Makefile-090907.diff
>> has said fix included. (Ironically enough, made manually to the diff
>> and untested... will I never learn?!?)
>>
>> And you're right on your second point too, it does work very well.
>
> Sounds like its good enough to at least commit to eclipse-devel?
>
http://rucci.org/ports/java/eclipse-europa/ contains a 'cleaned up'
version of the port:
* Included Mikes Makefile diff
* Removed unused files (or at least most of them?)
* ran portlint -A as per the porters-handbook and made some changes to
the Makefile to get rid of the errors, now it just gives the following
warnings:
WARN: Makefile: possible use of absolute pathname "/dev/null".
WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
portlint also suggests that programs such as eclipse should not list
java as its main category, I am not sure if we should follow its
recommendation or stick with the rest of the eclipse related ports. (or
maybe ports/eclipse/* ).
Dan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46E4F48E.2090904>