Date: Wed, 16 Sep 2009 14:28:05 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, freebsd-rc@freebsd.org Subject: Re: svn commit: r197196 - head/etc/rc.d Message-ID: <4AB15865.9030406@FreeBSD.org> In-Reply-To: <200909141652.n8EGqdd1060471@svn.freebsd.org> References: <200909141652.n8EGqdd1060471@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I personally would much prefer that people making changes in rc.d-land be more careful about what they change and thoroughly test their changes than to add more code like this that will both hide breakage and become stale over time. Doug Ed Maste wrote: > Author: emaste > Date: Mon Sep 14 16:52:38 2009 > New Revision: 197196 > URL: http://svn.freebsd.org/changeset/base/197196 > > Log: > Protect cross-script invocation by checking that the target script exists. > This allows pruning of rc.d scripts without getting too many ugly boottime > error messages. > > Inspired by phk's r128714 change to netif. > > Modified: > head/etc/rc.d/ppp > > Modified: head/etc/rc.d/ppp > ============================================================================== > --- head/etc/rc.d/ppp Mon Sep 14 16:16:07 2009 (r197195) > +++ head/etc/rc.d/ppp Mon Sep 14 16:52:38 2009 (r197196) > @@ -95,8 +95,12 @@ ppp_poststart() > { > # Re-Sync ipfilter and pf so they pick up any new network interfaces > # > - /etc/rc.d/ipfilter quietresync > - /etc/rc.d/pf quietresync > + if [ -f /etc/rc.d/ipfilter ]; then > + /etc/rc.d/ipfilter quietresync > + fi > + if [ -f /etc/rc.d/pf ]; then > + /etc/rc.d/pf quietresync > + fi > } > > ppp_stop_profile() { > -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AB15865.9030406>