Date: Sun, 7 Mar 2010 11:42:54 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204759 - in head: etc/defaults etc/rc.d share/man/man5 Message-ID: <20100307114254.00004897@unknown> In-Reply-To: <4B92AFE7.4040200@FreeBSD.org> References: <201003051434.o25EYXBR024375@svn.freebsd.org> <alpine.BSF.2.00.1003052113350.98935@serrsnyy.serrofq.bet> <20100306162535.000078b8@unknown> <4B92AFE7.4040200@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 06 Mar 2010 11:41:27 -0800 Doug Barton <dougb@FreeBSD.org>
wrote:
> On 3/6/2010 7:25 AM, Alexander Leidinger wrote:
> > The trick with command_args is neat, but it is a pitfall in case
> > someone wants to use it in the future. Wouldn't it be better to add
> > the ampersand to it instead of letting the ampersand replace the
> > value?
>
> Yes, obviously if someone wants to use command_args for an additional
> purpose down the road changes will have to be made. It's not in use
> atm however, so IMO simpler is better.
In general I agree to KISS, but the change now would be
command_args="${command_args}&"
which is not complex at all and is safer for the future.
Bye,
Alexander.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100307114254.00004897>