Date: Thu, 22 Aug 2013 01:12:44 -0600 From: Warner Losh <imp@bsdimp.com> To: Ilya Bakulin <ilya@bakulin.de> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, Alexander Motin <mav@freebsd.org>, "freebsd-embedded@freebsd.org" <freebsd-embedded@freebsd.org> Subject: Re: [PATCH] SDIO support for Globalscale Dreamplug Message-ID: <3C9989C8-BB72-4BD6-9246-4AD3790D4732@bsdimp.com> In-Reply-To: <5215AD32.3080800@bakulin.de> References: <20130702145905.GA1847@olymp.kibab.com> <51D3097A.8010601@FreeBSD.org> <51D3282C.1090701@bakulin.de> <C92CE8E1-75A0-459F-95DA-956D03DCB2E2@bsdimp.com> <20130703222002.GA60491@olymp.kibab.com> <51D50C55.1040300@myspectrum.nl> <51D531CB.3060300@bakulin.de> <51D5FE4C.9060102@bakulin.de> <20130821095849.GA7322@olymp.kibab.com> <CAJ-VmomavguSzg8z%2BRA81vv1KSAGrLWimQPZGZR_N9TkSymG-w@mail.gmail.com> <5215AD32.3080800@bakulin.de>
index | next in thread | previous in thread | raw e-mail
On Aug 22, 2013, at 12:18 AM, Ilya Bakulin wrote: > Hi Adrian, > > On 21.08.13 23:37, Adrian Chadd wrote: >> Hi! >> >> The marvell wifi stuff isn't ARM specific, right? So it should live in >> dev/ rather than arm/ > > Furthermore, it's only partly SDIO-specific. The same driver should work > for USB- and PCIe-based versions of Marvell Avastar 88W8787 and 88W8797. > The Linux driver is split into several files, by the way, for PCIe, USB > and SDIO, then for station and AP mode. We don't have any drivers in the tree that are this bus agnostic. Would be cool to grow some :) > I think the best way to organize the code is to split it in layers, like > it is for ath. > I didn't know that the code is going to be universal when I started to > code the driver, > so that's why if is in sys/arm/mv. Makes sense. > The code in Linux driver is clean and understandable, although I would > prefer to get the documentation for the chipset and not use Linux as the > single source of information. > What's with the licensing in this case by the way? Copying ideas and facts: no problem. Copying code: you must adhere to the license if you copied enough to be covered under copyright law.... It's complicated and best avoided.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C9989C8-BB72-4BD6-9246-4AD3790D4732>